GCTC-NTGC /
TalentCloud
| Conditions | 73 |
| Total Lines | 13 |
| Code Lines | 8 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
| Metric | Value |
|---|---|
| cc | 73 |
| eloc | 8 |
| dl | 0 |
| loc | 13 |
| rs | 0 |
| c | 0 |
| b | 0 |
| f | 0 |
Complex classes like reliability.js ➔ clone often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | // Clone Playground: JavaScript |
||
| 2 | |||
| 3 | // Age of Consent ============================================================== |
||
| 4 | $("[data-gc-parent-guardian-consent-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
|
|||
| 5 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 6 | |||
|
0 ignored issues
–
show
|
|||
| 7 | } else { |
||
| 8 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 9 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 10 | $("[data-gc-parent-guardian-consent]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 11 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 12 | $("[data-gc-personal-consent-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 13 | $("[data-gc-personal-consent]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 14 | } |
||
|
0 ignored issues
–
show
|
|||
| 15 | }); |
||
| 16 | |||
| 17 | $("[data-gc-personal-consent-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing  Loading history...
|
|||
| 18 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 19 | |||
|
0 ignored issues
–
show
|
|||
| 20 | } else { |
||
| 21 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 22 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 23 | $("[data-gc-personal-consent]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 24 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 25 | $("[data-gc-parent-guardian-consent-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 26 | $("[data-gc-parent-guardian-consent]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 27 | } |
||
|
0 ignored issues
–
show
|
|||
| 28 | }); |
||
| 29 | |||
| 30 | // Birth Name ================================================================== |
||
| 31 | $("[data-gc-birth-name-same-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 32 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 33 | |||
|
0 ignored issues
–
show
|
|||
| 34 | } else { |
||
| 35 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 36 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 37 | $("[data-gc-birth-name-different-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 38 | $("[data-gc-birth-name-different]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 39 | } |
||
|
0 ignored issues
–
show
|
|||
| 40 | }); |
||
| 41 | |||
| 42 | $("[data-gc-birth-name-different-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 43 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 44 | |||
|
0 ignored issues
–
show
|
|||
| 45 | } else { |
||
| 46 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 47 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 48 | $("[data-gc-birth-name-different]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 49 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 50 | $("[data-gc-birth-name-same-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 51 | $("[data-gc-birth-name-same]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 52 | } |
||
|
0 ignored issues
–
show
|
|||
| 53 | }); |
||
| 54 | |||
| 55 | // Legal Names ================================================================= |
||
| 56 | $("[data-gc-legal-name-same-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 57 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 58 | |||
|
0 ignored issues
–
show
|
|||
| 59 | } else { |
||
| 60 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 61 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 62 | $("[data-gc-legal-name-different-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 63 | $("[data-gc-legal-name-different]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 64 | } |
||
|
0 ignored issues
–
show
|
|||
| 65 | }); |
||
| 66 | |||
| 67 | $("[data-gc-legal-name-different-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 68 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 69 | |||
|
0 ignored issues
–
show
|
|||
| 70 | } else { |
||
| 71 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 72 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 73 | $("[data-gc-legal-name-different]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 74 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 75 | $("[data-gc-legal-name-same-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 76 | $("[data-gc-legal-name-same]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 77 | } |
||
|
0 ignored issues
–
show
|
|||
| 78 | }); |
||
| 79 | |||
| 80 | // Repeater ---------------------------------------------------------------- |
||
|
0 ignored issues
–
show
|
|||
| 81 | |||
| 82 | // Citizenship ================================================================= |
||
| 83 | $("[data-gc-citizen-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 84 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 85 | |||
|
0 ignored issues
–
show
|
|||
| 86 | } else { |
||
| 87 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 88 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 89 | $("[data-gc-citizen-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 90 | $("[data-gc-citizen-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 91 | } |
||
|
0 ignored issues
–
show
|
|||
| 92 | }); |
||
| 93 | |||
| 94 | $("[data-gc-citizen-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 95 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 96 | |||
|
0 ignored issues
–
show
|
|||
| 97 | } else { |
||
| 98 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 99 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 100 | $("[data-gc-citizen-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 101 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 102 | $("[data-gc-citizen-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 103 | $("[data-gc-citizen-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 104 | } |
||
|
0 ignored issues
–
show
|
|||
| 105 | }); |
||
| 106 | |||
| 107 | // Multiple Citizenship ======================================================== |
||
| 108 | $("[data-gc-multiple-citizen-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 109 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 110 | |||
|
0 ignored issues
–
show
|
|||
| 111 | } else { |
||
| 112 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 113 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 114 | $("[data-gc-multiple-citizen-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 115 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 116 | $("[data-gc-multiple-citizen-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 117 | $("[data-gc-multiple-citizen-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 118 | } |
||
|
0 ignored issues
–
show
|
|||
| 119 | }); |
||
| 120 | |||
| 121 | $("[data-gc-multiple-citizen-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 122 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 123 | |||
|
0 ignored issues
–
show
|
|||
| 124 | } else { |
||
| 125 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 126 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 127 | $("[data-gc-multiple-citizen-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 128 | $("[data-gc-multiple-citizen-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 129 | } |
||
|
0 ignored issues
–
show
|
|||
| 130 | }); |
||
| 131 | |||
| 132 | // Born Outside the Country ==================================================== |
||
| 133 | $("[data-gc-home-select]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 134 | if ($(this).val() === "Canada") { |
||
|
0 ignored issues
–
show
|
|||
| 135 | $("[data-gc-foreign-born]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 136 | } else { |
||
|
0 ignored issues
–
show
|
|||
| 137 | $("[data-gc-foreign-born]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 138 | } |
||
|
0 ignored issues
–
show
|
|||
| 139 | }); |
||
| 140 | |||
| 141 | // Naturalization ============================================================== |
||
| 142 | $("[data-gc-naturalization-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 143 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 144 | |||
|
0 ignored issues
–
show
|
|||
| 145 | } else { |
||
| 146 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 147 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 148 | $("[data-gc-naturalization-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 149 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 150 | $("[data-gc-naturalization-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 151 | $("[data-gc-naturalization-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 152 | } |
||
|
0 ignored issues
–
show
|
|||
| 153 | }); |
||
| 154 | |||
| 155 | $("[data-gc-naturalization-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 156 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 157 | |||
|
0 ignored issues
–
show
|
|||
| 158 | } else { |
||
| 159 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 160 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 161 | $("[data-gc-naturalization-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 162 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 163 | $("[data-gc-naturalization-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 164 | $("[data-gc-naturalization-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 165 | } |
||
|
0 ignored issues
–
show
|
|||
| 166 | }); |
||
| 167 | |||
| 168 | // Naturalization w/ Citizenship =============================================== |
||
| 169 | $("[data-gc-naturalization-application-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 170 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 171 | |||
|
0 ignored issues
–
show
|
|||
| 172 | } else { |
||
| 173 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 174 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 175 | $("[data-gc-naturalization-application-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 176 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 177 | $("[data-gc-naturalization-application-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 178 | $("[data-gc-naturalization-application-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 179 | } |
||
|
0 ignored issues
–
show
|
|||
| 180 | }); |
||
| 181 | |||
| 182 | $("[data-gc-naturalization-application-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 183 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 184 | |||
|
0 ignored issues
–
show
|
|||
| 185 | } else { |
||
| 186 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 187 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 188 | $("[data-gc-naturalization-application-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 189 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 190 | $("[data-gc-naturalization-application-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 191 | $("[data-gc-naturalization-application-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 192 | } |
||
|
0 ignored issues
–
show
|
|||
| 193 | }); |
||
| 194 | |||
| 195 | // Previous Screening ========================================================== |
||
| 196 | |||
| 197 | // Applications |
||
|
0 ignored issues
–
show
|
|||
| 198 | $("[data-gc-screen-apply-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 199 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 200 | |||
|
0 ignored issues
–
show
|
|||
| 201 | } else { |
||
| 202 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 203 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 204 | $("[data-gc-screen-apply-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 205 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 206 | $("[data-gc-screen-apply-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 207 | $("[data-gc-screen-apply-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 208 | } |
||
|
0 ignored issues
–
show
|
|||
| 209 | }); |
||
|
0 ignored issues
–
show
|
|||
| 210 | |||
| 211 | $("[data-gc-screen-apply-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 212 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 213 | |||
|
0 ignored issues
–
show
|
|||
| 214 | } else { |
||
| 215 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 216 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 217 | $("[data-gc-screen-apply-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 218 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 219 | $("[data-gc-screen-apply-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 220 | $("[data-gc-screen-apply-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 221 | } |
||
|
0 ignored issues
–
show
|
|||
| 222 | }); |
||
|
0 ignored issues
–
show
|
|||
| 223 | |||
| 224 | // Granted |
||
|
0 ignored issues
–
show
|
|||
| 225 | $("[data-gc-screen-granted-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 226 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 227 | |||
|
0 ignored issues
–
show
|
|||
| 228 | } else { |
||
| 229 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 230 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 231 | $("[data-gc-screen-granted-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 232 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 233 | $("[data-gc-screen-granted-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 234 | $("[data-gc-screen-granted-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 235 | } |
||
|
0 ignored issues
–
show
|
|||
| 236 | }); |
||
|
0 ignored issues
–
show
|
|||
| 237 | |||
| 238 | $("[data-gc-screen-granted-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 239 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 240 | |||
|
0 ignored issues
–
show
|
|||
| 241 | } else { |
||
| 242 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 243 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 244 | $("[data-gc-screen-granted-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 245 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 246 | $("[data-gc-screen-granted-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 247 | $("[data-gc-screen-granted-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 248 | } |
||
|
0 ignored issues
–
show
|
|||
| 249 | }); |
||
|
0 ignored issues
–
show
|
|||
| 250 | |||
| 251 | // Revoked |
||
|
0 ignored issues
–
show
|
|||
| 252 | $("[data-gc-screen-revoked-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 253 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 254 | |||
|
0 ignored issues
–
show
|
|||
| 255 | } else { |
||
| 256 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 257 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 258 | $("[data-gc-screen-revoked-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 259 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 260 | $("[data-gc-screen-revoked-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 261 | $("[data-gc-screen-revoked-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 262 | } |
||
|
0 ignored issues
–
show
|
|||
| 263 | }); |
||
|
0 ignored issues
–
show
|
|||
| 264 | |||
| 265 | $("[data-gc-screen-revoked-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 266 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 267 | |||
| 268 | } else { |
||
|
0 ignored issues
–
show
|
|||
| 269 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 270 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 271 | $("[data-gc-screen-revoked-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 272 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 273 | $("[data-gc-screen-revoked-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 274 | $("[data-gc-screen-revoked-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 275 | } |
||
|
0 ignored issues
–
show
|
|||
| 276 | }); |
||
|
0 ignored issues
–
show
|
|||
| 277 | |||
| 278 | // Denied |
||
|
0 ignored issues
–
show
|
|||
| 279 | $("[data-gc-screen-denied-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 280 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 281 | |||
|
0 ignored issues
–
show
|
|||
| 282 | } else { |
||
| 283 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 284 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 285 | $("[data-gc-screen-denied-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 286 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 287 | $("[data-gc-screen-denied-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 288 | $("[data-gc-screen-denied-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 289 | } |
||
|
0 ignored issues
–
show
|
|||
| 290 | }); |
||
|
0 ignored issues
–
show
|
|||
| 291 | |||
| 292 | $("[data-gc-screen-denied-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 293 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 294 | |||
|
0 ignored issues
–
show
|
|||
| 295 | } else { |
||
| 296 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 297 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 298 | $("[data-gc-screen-denied-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 299 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 300 | $("[data-gc-screen-denied-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 301 | $("[data-gc-screen-denied-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 302 | } |
||
|
0 ignored issues
–
show
|
|||
| 303 | }); |
||
|
0 ignored issues
–
show
|
|||
| 304 | |||
| 305 | // Current Address ============================================================= |
||
| 306 | $("[data-gc-current-address-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 307 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 308 | $(this).removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 309 | $("[data-gc-current-address]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 310 | } else { |
||
|
0 ignored issues
–
show
|
|||
| 311 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 312 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 313 | $("[data-gc-current-address]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 314 | } |
||
|
0 ignored issues
–
show
|
|||
| 315 | }); |
||
| 316 | |||
| 317 | // Current Experience ========================================================== |
||
| 318 | $("[data-gc-current-experience-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 319 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 320 | $(this).removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 321 | $("[data-gc-current-experience]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 322 | } else { |
||
|
0 ignored issues
–
show
|
|||
| 323 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 324 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 325 | $("[data-gc-current-experience]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 326 | } |
||
|
0 ignored issues
–
show
|
|||
| 327 | }); |
||
| 328 | |||
| 329 | // Experience Unemployment |
||
| 330 | $("[data-gc-experience-unemployed-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 331 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 332 | |||
|
0 ignored issues
–
show
|
|||
| 333 | } else { |
||
| 334 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 335 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 336 | $("[data-gc-experience-unemployed-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 337 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 338 | $("[data-gc-experience-unemployed-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 339 | $("[data-gc-experience-unemployed-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 340 | dialogSizing($("[data-c-dialog][data-c-dialog-id=\"experience-dialog\"]")); |
||
|
0 ignored issues
–
show
|
|||
| 341 | } |
||
|
0 ignored issues
–
show
|
|||
| 342 | }); |
||
| 343 | |||
| 344 | $("[data-gc-experience-unemployed-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 345 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 346 | |||
|
0 ignored issues
–
show
|
|||
| 347 | } else { |
||
| 348 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 349 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 350 | $("[data-gc-experience-unemployed-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 351 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 352 | $("[data-gc-experience-unemployed-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 353 | $("[data-gc-experience-unemployed-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 354 | dialogSizing($("[data-c-dialog][data-c-dialog-id=\"experience-dialog\"]")); |
||
|
0 ignored issues
–
show
|
|||
| 355 | } |
||
|
0 ignored issues
–
show
|
|||
| 356 | }); |
||
| 357 | |||
| 358 | // Experience Dismissal |
||
| 359 | $("[data-gc-experience-dismissal-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 360 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 361 | |||
|
0 ignored issues
–
show
|
|||
| 362 | } else { |
||
| 363 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 364 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 365 | $("[data-gc-experience-dismissal-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 366 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 367 | $("[data-gc-experience-dismissal-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 368 | $("[data-gc-experience-dismissal-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 369 | dialogSizing($("[data-c-dialog][data-c-dialog-id=\"experience-dialog\"]")); |
||
|
0 ignored issues
–
show
|
|||
| 370 | } |
||
|
0 ignored issues
–
show
|
|||
| 371 | }); |
||
| 372 | |||
| 373 | $("[data-gc-experience-dismissal-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 374 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 375 | |||
| 376 | } else { |
||
|
0 ignored issues
–
show
|
|||
| 377 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 378 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 379 | $("[data-gc-experience-dismissal-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 380 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 381 | $("[data-gc-experience-dismissal-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 382 | $("[data-gc-experience-dismissal-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 383 | dialogSizing($("[data-c-dialog][data-c-dialog-id=\"experience-dialog\"]")); |
||
|
0 ignored issues
–
show
|
|||
| 384 | } |
||
|
0 ignored issues
–
show
|
|||
| 385 | }); |
||
| 386 | |||
| 387 | // Experience Supervisor |
||
| 388 | $("[data-gc-experience-supervisor-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 389 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 390 | |||
|
0 ignored issues
–
show
|
|||
| 391 | } else { |
||
| 392 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 393 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 394 | $("[data-gc-experience-supervisor-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 395 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 396 | $("[data-gc-experience-supervisor-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 397 | $("[data-gc-experience-supervisor-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 398 | dialogSizing($("[data-c-dialog][data-c-dialog-id=\"experience-dialog\"]")); |
||
|
0 ignored issues
–
show
|
|||
| 399 | } |
||
|
0 ignored issues
–
show
|
|||
| 400 | }); |
||
| 401 | |||
| 402 | $("[data-gc-experience-supervisor-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 403 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 404 | |||
|
0 ignored issues
–
show
|
|||
| 405 | } else { |
||
| 406 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 407 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 408 | $("[data-gc-experience-supervisor-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 409 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 410 | $("[data-gc-experience-supervisor-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 411 | $("[data-gc-experience-supervisor-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 412 | dialogSizing($("[data-c-dialog][data-c-dialog-id=\"experience-dialog\"]")); |
||
|
0 ignored issues
–
show
|
|||
| 413 | } |
||
|
0 ignored issues
–
show
|
|||
| 414 | }); |
||
| 415 | |||
| 416 | // Reference Work/Education |
||
| 417 | $("[data-gc-reference-work-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 418 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 419 | |||
|
0 ignored issues
–
show
|
|||
| 420 | } else { |
||
| 421 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 422 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 423 | $("[data-gc-reference-work-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 424 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 425 | $("[data-gc-reference-work-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 426 | $("[data-gc-reference-work-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 427 | } |
||
|
0 ignored issues
–
show
|
|||
| 428 | }); |
||
| 429 | |||
| 430 | $("[data-gc-reference-work-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 431 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 432 | |||
|
0 ignored issues
–
show
|
|||
| 433 | } else { |
||
| 434 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 435 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 436 | $("[data-gc-reference-work-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 437 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 438 | $("[data-gc-reference-work-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 439 | $("[data-gc-reference-work-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 440 | } |
||
|
0 ignored issues
–
show
|
|||
| 441 | }); |
||
| 442 | |||
| 443 | // Record |
||
| 444 | $("[data-gc-record-true-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 445 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 446 | |||
|
0 ignored issues
–
show
|
|||
| 447 | } else { |
||
| 448 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 449 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 450 | $("[data-gc-record-true]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 451 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 452 | $("[data-gc-record-false-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 453 | $("[data-gc-record-false]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 454 | } |
||
|
0 ignored issues
–
show
|
|||
| 455 | }); |
||
| 456 | |||
| 457 | $("[data-gc-record-false-trigger]").on("click", function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 458 | if ($(this).hasClass("active")) { |
||
|
0 ignored issues
–
show
|
|||
| 459 | |||
| 460 | } else { |
||
|
0 ignored issues
–
show
|
|||
| 461 | // Triger this elements stuff. |
||
|
0 ignored issues
–
show
|
|||
| 462 | $(this).addClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 463 | $("[data-gc-record-false]").removeClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 464 | // Remove alternative option's stuff. |
||
|
0 ignored issues
–
show
|
|||
| 465 | $("[data-gc-record-true-trigger]").removeClass("active"); |
||
|
0 ignored issues
–
show
|
|||
| 466 | $("[data-gc-record-true]").addClass("hidden"); |
||
|
0 ignored issues
–
show
|
|||
| 467 | } |
||
|
0 ignored issues
–
show
|
|||
| 468 | }); |
||
| 469 | |||
| 470 | // Clone Stuff |
||
| 471 | // Clone Shorthand ============================================================= |
||
| 472 | function clone(attr, option, selector) { |
||
|
0 ignored issues
–
show
|
|||
| 473 | if (option != null) { |
||
|
0 ignored issues
–
show
|
|||
| 474 | if (selector != null) { |
||
|
0 ignored issues
–
show
|
|||
| 475 | return '[data-c-' + attr + selector + '=\'' + option + '\']'; |
||
|
0 ignored issues
–
show
|
|||
| 476 | } |
||
|
0 ignored issues
–
show
|
|||
| 477 | else { |
||
|
0 ignored issues
–
show
|
|||
| 478 | return '[data-c-' + attr + '=\'' + option + '\']'; |
||
|
0 ignored issues
–
show
|
|||
| 479 | } |
||
|
0 ignored issues
–
show
|
|||
| 480 | } |
||
|
0 ignored issues
–
show
|
|||
| 481 | else { |
||
|
0 ignored issues
–
show
|
|||
| 482 | return '[data-c-' + attr + ']'; |
||
|
0 ignored issues
–
show
|
|||
| 483 | } |
||
|
0 ignored issues
–
show
|
|||
| 484 | } |
||
| 485 | // Dialog Sizing ------------------------------------------------------- |
||
| 486 | function dialogSizing(dialog) { |
||
|
0 ignored issues
–
show
|
|||
| 487 | var viewportHeight = $(window).height(); |
||
|
0 ignored issues
–
show
Instead of
var consider using ECMAScript 6's const or let which have stricter semantics.
Further Readings: Loading history...
|
|||
| 488 | if (dialog != null) { |
||
|
0 ignored issues
–
show
|
|||
| 489 | var dialogHeight = $(dialog).children("div").height() + 50; |
||
|
0 ignored issues
–
show
Instead of
var consider using ECMAScript 6's const or let which have stricter semantics.
Further Readings: Loading history...
|
|||
| 490 | if (dialogHeight > viewportHeight) { |
||
|
0 ignored issues
–
show
|
|||
| 491 | $(dialog).attr("data-c-dialog", "active--overflowing"); |
||
|
0 ignored issues
–
show
|
|||
| 492 | } |
||
|
0 ignored issues
–
show
|
|||
| 493 | else { |
||
| 494 | $(dialog).attr("data-c-dialog", "active--contained"); |
||
|
0 ignored issues
–
show
|
|||
| 495 | } |
||
|
0 ignored issues
–
show
|
|||
| 496 | } |
||
|
0 ignored issues
–
show
|
|||
| 497 | else { |
||
| 498 | $(clone("dialog")).each(function() { |
||
|
0 ignored issues
–
show
Unexpected unnamed function.
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces: MyClass.prototype.someFunction = function someFunction() {
}
As you can see, someFunction is repeated twice above. Instead of having
stack traces referencing Loading history...
|
|||
| 499 | if ($(this).attr("data-c-dialog") == false){ |
||
|
0 ignored issues
–
show
Apart from some edge-cases, it is generally advisable to use the strict comparison
=== instead of ==.
The loose comparison such as Loading history...
|
|||
| 500 | return false; |
||
|
0 ignored issues
–
show
|
|||
| 501 | } |
||
|
0 ignored issues
–
show
|
|||
| 502 | else { |
||
|
0 ignored issues
–
show
|
|||
| 503 | var dialogHeight = $(this).children("div").height() + 50; |
||
|
0 ignored issues
–
show
Instead of
var consider using ECMAScript 6's const or let which have stricter semantics.
Further Readings: Loading history...
|
|||
| 504 | if (dialogHeight > viewportHeight) { |
||
|
0 ignored issues
–
show
|
|||
| 505 | $(this).attr("data-c-dialog", "active--overflowing"); |
||
|
0 ignored issues
–
show
|
|||
| 506 | } |
||
|
0 ignored issues
–
show
|
|||
| 507 | else { |
||
| 508 | $(this).attr("data-c-dialog", "active--contained"); |
||
|
0 ignored issues
–
show
|
|||
| 509 | } |
||
|
0 ignored issues
–
show
|
|||
| 510 | } |
||
|
0 ignored issues
–
show
|
|||
| 511 | }); |
||
|
0 ignored issues
–
show
|
|||
| 512 | } |
||
|
0 ignored issues
–
show
|
|||
| 513 | } |
||
| 514 |
It is becoming a best practice to add a name even to function expressions to aid in debugging as it produces better stack traces:
As you can see, someFunction is repeated twice above. Instead of having stack traces referencing
anonymous function, you will now see the actual function name that was called.